Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BootstrapEntry struct in sync with that in Porx repo #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make BootstrapEntry struct in sync with that in Porx repo #136

wants to merge 1 commit into from

Conversation

gohilankit
Copy link

@gohilankit gohilankit commented Nov 6, 2024 •
edited
Loading

What this PR does / why we need it:
The BootstrapEntry struct in porx project has more fields added over the time, which are missing here. This PR just brings it in sync.

Output of make build command:

>  make build
PKGS=github.com/portworx/kvdb github.com/portworx/kvdb/api/bootstrap github.com/portworx/kvdb/api/bootstrap/k8s github.com/portworx/kvdb/bolt github.com/portworx/kvdb/common github.com/portworx/kvdb/consul github.com/portworx/kvdb/etcd/common github.com/portworx/kvdb/etcd/v3 github.com/portworx/kvdb/mem github.com/portworx/kvdb/wrappers github.com/portworx/kvdb/zookeeper
>>> go build
go build github.com/portworx/kvdb github.com/portworx/kvdb/api/bootstrap github.com/portworx/kvdb/api/bootstrap/k8s github.com/portworx/kvdb/bolt github.com/portworx/kvdb/common github.com/portworx/kvdb/consul github.com/portworx/kvdb/etcd/common github.com/portworx/kvdb/etcd/v3 github.com/portworx/kvdb/mem github.com/portworx/kvdb/wrappers github.com/portworx/kvdb/zookeeper

@gohilankit gohilankit force-pushed the PWX-38380-bootstrap-entry-sync branch from b6ea1b8 to 8c2c8e5 Compare November 6, 2024 17:21
Make BootstrapEntry struct in sync with that in Porx repo
5dbd3b9 
Signed-off-by: Ankit Gohil <agohil@purestorage.com>
@gohilankit gohilankit force-pushed the PWX-38380-bootstrap-entry-sync branch from 8c2c8e5 to 5dbd3b9 Compare November 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pureneelesh pureneelesh pureneelesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gohilankit @pureneelesh